Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log less details about the targets #16405

Merged
merged 1 commit into from
Nov 7, 2017
Merged

Log less details about the targets #16405

merged 1 commit into from
Nov 7, 2017

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented Nov 7, 2017

Log less details about the targets to prevent queue being bloated by targeted refresh data,

@Ladas
Log less details about the targets
73d9e0e 
Log less details about the targets
@Ladas
Copy link
Contributor Author

Ladas commented Nov 7, 2017

@miq-bot assign @agrare

@miq-bot
Copy link
Member

miq-bot commented Nov 7, 2017

Checked commit Ladas@73d9e0e with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

agrare
agrare approved these changes Nov 7, 2017
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 confirmed this reduces the logging significantly for watch collector

@agrare agrare merged commit 98d5ff6 into ManageIQ:master Nov 7, 2017
@agrare agrare added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 7, 2017
simaishi pushed a commit that referenced this pull request Nov 7, 2017
@agrare @simaishi
Merge pull request #16405 from Ladas/log_less_details_about_the_targets
41d1642 
Log less details about the targets
(cherry picked from commit 98d5ff6)
@simaishi
Copy link
Contributor

simaishi commented Nov 7, 2017

Gaprindashvili backport details:

$ git log -1
commit 41d164226214a098761d8aee77592763354770ca
Author: Adam Grare <agrare@redhat.com>
Date:   Tue Nov 7 10:30:33 2017 -0500

    Merge pull request #16405 from Ladas/log_less_details_about_the_targets
    
    Log less details about the targets
    (cherry picked from commit 98d5ff64e90939d23a7316641bdfa7088a16e289)

@jhernand jhernand mentioned this pull request Nov 7, 2017
Merged
@agrare agrare mentioned this pull request Nov 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
bug gaprindashvili/backported providers/inventory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ladas @miq-bot @simaishi @agrare